MSVC and clang-cl QoL improvements #3808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang-cl has its own compiler id but supports MSVC argument conventions. Use get_argument_syntax to recognize MSVC-like compilers generally.
clang-cl accepts both style of options but these will be generally meaningless: - Static CRT is unnecessary. - File alignment will be introduced in another commit. - Wine has partial support for PDB backtrace so there is probably no need to insist on DWARF (which is unsupported by real MSVC anyway). - MSVC doesn't have the weird stdcall ordinal naming convention that necessiates fixup and kill-at.
Useful if you want to run a MSVC build on Wine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been playing with using clang-cl in combination with https://github.com/mstorsjo/msvc-wine to cross-compile against MSVC C/C++ runtime on Linux. You can see an example of cross file here.
Right now, the upside is smaller binary size as you don't need to link in the C/C++ runtime statically. In the future there might be other reasons to use this, such as when better STL support is wanted.
The PR is some small changes for build flags to ensure this setup works smoothly.